Increase CSI param limit to 256 to match Kitty #6194
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
reviewed
Sep 25, 2024
| @@ -422,7 +422,7 @@ impl VTParser { | |||
| full: false, | |||
| }, | |||
|
|
|||
| params: Default::default(), | |||
| params: [CsiParam::Integer(0); MAX_PARAMS], | |||
There was a problem hiding this comment.
Default::default() doesn't work on 256 element long arrays - at least, I couldn't get it to work.
|
@wez, I'm tremendously sorry it took me so long to get back to this PR. I cleaned up the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current WezTerm master, the maximum number of params a CSI sequence is allowed to have is 32, which is too low to successfully parse some perfectly valid CSI sequences as described here: #5161.
This PR increases this limit to 256 params, as this is what the Kitty terminal emulator uses.
One unfortunate side effect is that due to this change, the byte string in the csi_too_many_params test now needs to have 257 params in its CSI sequence, which makes the test rather unwieldy. I am open to suggestions on how to improve this situation.