Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is a 1.4.2 or later version of darwin, but seems extra is gone. #23

Closed
wants to merge 1 commit into from
Closed

It is a 1.4.2 or later version of darwin, but seems extra is gone. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions libexec/goenv-install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ if [ "$platform" = "darwin" ]; then
extra="-osx10.6"
fi
fi
# 1.4.3 later extra none
if [ "$version" \> "1.4.2" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use the vercomp function? Feel free to move the definition of vercomp up.

extra=""
fi
fi




function vercomp () {
# http://stackoverflow.com/questions/4023830
# 0: '='
Expand Down Expand Up @@ -88,8 +89,9 @@ if [ "$rtn" == "1" ]
then
download="http://golang.org/dl/go${version}.${platform}-${arch}${extra}.tar.gz"
else
download="https://go.googlecode.com/files/go${version}.${platform}-${arch}${extra}.tar.gz"
download="https://storage.googleapis.com/golang/go${version}.${platform}-${arch}${extra}.tar.gz"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is only changing the URL for downloads up to 1.2. Should this be a change to the first download url (golang.org), instead?

fi

# Can't get too clever here
set +e

Expand Down