Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi users #42

Closed
wants to merge 2 commits into from
Closed

Multi users #42

wants to merge 2 commits into from

Conversation

nileshpatra
Copy link
Contributor

solves #15
Removed the last while loop, since it wasn't really doing anything much, just keeping track without outputting anything

@whatsplay whatsplay deleted a comment Aug 14, 2019
@whatsplay whatsplay deleted a comment Aug 14, 2019
Copy link
Member

@rpotter12 rpotter12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nileshpatra If the loop is removed then the script will print the current online status after every one second and that is not needed. The idea is to print the status whenever the person gets online. And the second thing is that from your PR the user can not track the online status for all persons at a time, the script will check for another name when the first one is close.

@nileshpatra
Copy link
Contributor Author

@rpotter12 will change that. But the status is not getting out properly, as to when the person comes online. I feel that the last while loop is incomplete - it doesn't serve the purpose exactly. What I mean t say is that the loop goes on regardless of the fact whether or not the person is online.

@rpotter12
Copy link
Member

@nileshpatra the second loop is just stopping to print online status after every second.
Please propose your changes I will then review the PR. And please make different PR for different task(1 PR = 1 task). :)

@rpotter12
Copy link
Member

@nileshpatra please make a new PR after solving this issue :)

@rpotter12 rpotter12 closed this Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants