Skip to content

Commit

Permalink
Fix double "update the navigation API" for fragment navs
Browse files Browse the repository at this point in the history
Closes #9826. da3a62e made it easy to pass along the correct navigationType, and thus trigger the proper path through "update the navigation API entries for a same-document navigation".

Also fixes a typographical issue from da3a62e.
  • Loading branch information
domenic committed Dec 13, 2023
1 parent da3a62e commit 304b15b
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -98330,9 +98330,6 @@ location.href = '#foo';</code></pre>
untouched, and no events are fired.</p>
</li>

<li><p><span>Update the navigation API entries for a same-document navigation</span> given
<var>navigation</var>, <var>historyEntry</var>, and <var>historyHandling</var>.</p></li>

<li>
<p><span>Scroll to the fragment</span> given <var>navigable</var>'s <span
data-x="nav-document">active document</span>.</p>
Expand Down Expand Up @@ -100518,18 +100515,18 @@ location.href = '#foo';</code></pre>
data-x="she-document-state">document state</span>'s <span
data-x="document-state-reload-pending">reload pending</span> is true.</p></dd>

<dt>"<span data-x="dom-NavigationType-traverse">traverse</span>"</dt>
<dt>"<code data-x="dom-NavigationType-traverse">traverse</code>"</dt>
<dd><p><span>Assert</span>: <var>targetEntry</var>'s
<span data-x="she-document-state">document state</span>'s <span
data-x="document-state-ever-populated">ever populated</span> is true.</p></dd>

<dt>"<span data-x="dom-NavigationType-replace">replace</span>"</dt>
<dt>"<code data-x="dom-NavigationType-replace">replace</code>"</dt>
<dd><p><span>Assert</span>: <var>targetEntry</var>'s <span data-x="she-step">step</span>
is <var>displayedEntry</var>'s <span data-x="she-step">step</span> and
<var>targetEntry</var>'s <span data-x="she-document-state">document state</span>'s <span
data-x="document-state-ever-populated">ever populated</span> is false.</p></dd>

<dt>"<span data-x="dom-NavigationType-push">push</span>"</dt>
<dt>"<code data-x="dom-NavigationType-push">push</code>"</dt>
<dd><p><span>Assert</span>: <var>targetEntry</var>'s <span data-x="she-step">step</span> is
<var>displayedEntry</var>'s <span data-x="she-step">step</span> + 1 and
<var>targetEntry</var>'s <span data-x="she-document-state">document state</span>'s <span
Expand Down Expand Up @@ -101189,9 +101186,10 @@ location.href = '#foo';</code></pre>
<p>If <var>documentIsNew</var> is false, then:</p>

<ol>
<li><p><span>Assert</span>: <var>navigationType</var> is not null.</p></li>

<li><p><span>Update the navigation API entries for a same-document navigation</span> given
<var>navigation</var>, <var>entry</var>, and "<code
data-x="dom-NavigationType-traverse">traverse</code>".</p></li>
<var>navigation</var>, <var>entry</var>, and <var>navigationType</var>.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-popstate">popstate</code> at <var>document</var>'s <span>relevant global
Expand Down

0 comments on commit 304b15b

Please sign in to comment.