Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing character renders in Tokenization #10880

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add missing character renders in Tokenization #10880

merged 1 commit into from
Jan 14, 2025
+3 −3

Conversation

AMS21
Copy link
Contributor

@AMS21 AMS21 commented Dec 20, 2024 •
edited by pr-preview bot
Loading

Notices these small inconsistencies while implementing the state machine.

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • Corresponding HTML AAM & ARIA in HTML issues & PRs:
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/parsing.html ( diff )

annevk
annevk approved these changes Jan 13, 2025
View reviewed changes
source Outdated Show resolved Hide resolved
@AMS21 AMS21 force-pushed the missing_character_renders_tokenizer_state_machine branch from 6891a35 to 36a8cb8 Compare January 13, 2025 19:05
@AMS21 AMS21 force-pushed the missing_character_renders_tokenizer_state_machine branch from 36a8cb8 to 5a8f6fc Compare January 13, 2025 19:08
@annevk annevk merged commit ad1450d into whatwg:main Jan 14, 2025
2 checks passed
@annevk
Copy link
Member

annevk commented Jan 14, 2025

Thanks!

@AMS21 AMS21 deleted the missing_character_renders_tokenizer_state_machine branch January 14, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMS21 @annevk