Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation API : "activation info" #9856

Merged
merged 22 commits into from
Dec 13, 2023
Merged

Navigation API : "activation info" #9856

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
da3852a
Activation info
noamr Oct 16, 2023
5dfe5e6
Handle initial about:blank
noamr Oct 16, 2023
a88fd59
Apply SOME of the CR comments
noamr Oct 17, 2023
be3b997
Move activation info resolving to update-history
noamr Oct 17, 2023
f85de8e
Deal with nullable things
noamr Oct 17, 2023
bb9ad3e
Propagate navigationType to applyHistoryStep
noamr Oct 17, 2023
0fa080d
Add domintro
noamr Oct 17, 2023
2aac8d4
formatting
noamr Oct 17, 2023
c2af36f
formatting
noamr Oct 17, 2023
789c498
tidbits
noamr Oct 17, 2023
e0d58b8
tidbits
noamr Oct 17, 2023
b58d3ee
Some line spacing things
noamr Oct 17, 2023
5d495b3
Apply PR comments
noamr Oct 19, 2023
77adc13
Some more nits
noamr Oct 20, 2023
d6aec96
Amended note to cover .entry
noamr Oct 24, 2023
cee54d8
Add missing 'be'
noamr Oct 31, 2023
3ea53f7
Change constraints for orphan entry
noamr Nov 16, 2023
ad167fe
Revert "Change constraints for orphan entry"
noamr Nov 17, 2023
14ffb8c
Clarify when orphan entries are allowed
noamr Nov 17, 2023
7e7762a
Revise if clause
noamr Nov 20, 2023
4a1bec3
Revise if clause
noamr Nov 20, 2023
5c32c61
nit
noamr Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92163,13 +92163,16 @@ interface <dfn interface>NavigationActivation</dfn> {
right before the current <code>Document</code>. This might have a value null in case the
previous <code>Document</code> was not <span>same origin</span> with this one.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"might" is a bit confusing here. Is the value null or is it not when the previous document was cross origin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's null in that case... will reword.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


<p>In case the <code>Document</code> was activated using <code
data-x="dom-location-replace">location.replace()</code>, the <code
data-x="dom-NavigationActivation-from">from</code> entry would not be a viable target for the
<code data-x="dom-Navigation-traverseTo">traverseTo()</code> method as it's not retained in
history. However, its <code data-x="dom-NavigationHistoryEntry-url">url</code> property and
<code data-x="dom-NavigationHistoryEntry-getState">getState()</code> method are still
accessible.</p>
<p>There are some cases in which either the <code
data-x="dom-NavigationActivation-from">from</code> or <code
data-x="dom-NavigationActivation-entry">entry</code> <code>NavigationHistoryEntry</code> objects
would not be viable targets for the <code data-x="dom-Navigation-traverseTo">traverseTo()</code>
noamr marked this conversation as resolved.
Show resolved Hide resolved
method, as they might not retained in history. For example, the <code>Document</code> can be
noamr marked this conversation as resolved.
Show resolved Hide resolved
noamr marked this conversation as resolved.
Show resolved Hide resolved
noamr marked this conversation as resolved.
Show resolved Hide resolved
activated using <code data-x="dom-location-replace">location.replace()</code> or its initial
noamr marked this conversation as resolved.
Show resolved Hide resolved
entry could be replaced by <code
noamr marked this conversation as resolved.
Show resolved Hide resolved
data-x="dom-history-replaceState">history.replaceState()</code>. However, those entries' <code
data-x="dom-NavigationHistoryEntry-url">url</code> property and <code
data-x="dom-NavigationHistoryEntry-getState">getState()</code> method are still accessible.</p>
</dd>

<dt><code data-x=""><span data-x="dom-navigation">navigation</span>.<span data-x="dom-Navigation-activation">activation</span>.<span subdfn data-x="dom-NavigationActivation-navigationType">navigationType</span></code></dt>
Expand Down