Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double "update the navigation API" for fragment navs #9990

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix double "update the navigation API" for fragment navs #9990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98330,9 +98330,6 @@ location.href = '#foo';</code></pre>
untouched, and no events are fired.</p>
</li>

<li><p><span>Update the navigation API entries for a same-document navigation</span> given
<var>navigation</var>, <var>historyEntry</var>, and <var>historyHandling</var>.</p></li>

<li>
<p><span>Scroll to the fragment</span> given <var>navigable</var>'s <span
data-x="nav-document">active document</span>.</p>
Expand Down Expand Up @@ -100518,18 +100515,18 @@ location.href = '#foo';</code></pre>
data-x="she-document-state">document state</span>'s <span
data-x="document-state-reload-pending">reload pending</span> is true.</p></dd>

<dt>"<span data-x="dom-NavigationType-traverse">traverse</span>"</dt>
<dt>"<code data-x="dom-NavigationType-traverse">traverse</code>"</dt>
<dd><p><span>Assert</span>: <var>targetEntry</var>'s
<span data-x="she-document-state">document state</span>'s <span
data-x="document-state-ever-populated">ever populated</span> is true.</p></dd>

<dt>"<span data-x="dom-NavigationType-replace">replace</span>"</dt>
<dt>"<code data-x="dom-NavigationType-replace">replace</code>"</dt>
<dd><p><span>Assert</span>: <var>targetEntry</var>'s <span data-x="she-step">step</span>
is <var>displayedEntry</var>'s <span data-x="she-step">step</span> and
<var>targetEntry</var>'s <span data-x="she-document-state">document state</span>'s <span
data-x="document-state-ever-populated">ever populated</span> is false.</p></dd>

<dt>"<span data-x="dom-NavigationType-push">push</span>"</dt>
<dt>"<code data-x="dom-NavigationType-push">push</code>"</dt>
<dd><p><span>Assert</span>: <var>targetEntry</var>'s <span data-x="she-step">step</span> is
<var>displayedEntry</var>'s <span data-x="she-step">step</span> + 1 and
<var>targetEntry</var>'s <span data-x="she-document-state">document state</span>'s <span
Expand Down Expand Up @@ -101189,9 +101186,10 @@ location.href = '#foo';</code></pre>
<p>If <var>documentIsNew</var> is false, then:</p>

<ol>
<li><p><span>Assert</span>: <var>navigationType</var> is not null.</p></li>

<li><p><span>Update the navigation API entries for a same-document navigation</span> given
<var>navigation</var>, <var>entry</var>, and "<code
data-x="dom-NavigationType-traverse">traverse</code>".</p></li>
<var>navigation</var>, <var>entry</var>, and <var>navigationType</var>.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-popstate">popstate</code> at <var>document</var>'s <span>relevant global
Expand Down