fix: trust new identities #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gferon
force-pushed
the
trust-new-identities
branch
2 times, most recently
from
08f230a to
6c99e03
Compare
gferon
force-pushed
the
trust-new-identities
branch
from
6c99e03 to
8d77ae1
Compare
gferon
force-pushed
the
trust-new-identities
branch
from
7ccf13b to
ec44a50
Compare
Schmiddiii
added a commit
to Schmiddiii/presage
that referenced
this pull request
Nov 28, 2023
Outgoing messages in 1-to-1 chats were stored in the note-to-self chat. This was broken in 6125534. This will be fixed by this MR. This also fixes the timestamp of identity verification messages, which are inserted into the store by presage. By convention, all timestamps used are in milliseconds, this one was in seconds. This was wrong since whisperfish#206.
Schmiddiii
added a commit
to Schmiddiii/presage
that referenced
this pull request
Nov 29, 2023
Outgoing messages in 1-to-1 chats were stored in the note-to-self chat. This was broken in 6125534. This will be fixed by this MR. This also fixes the timestamp of identity verification messages, which are inserted into the store by presage. By convention, all timestamps used are in milliseconds, this one was in seconds. This was wrong since whisperfish#206.
gferon
pushed a commit
that referenced
this pull request
Dec 5, 2023
Outgoing messages in 1-to-1 chats were stored in the note-to-self chat. This was broken in 6125534. This will be fixed by this MR. This also fixes the timestamp of identity verification messages, which are inserted into the store by presage. By convention, all timestamps used are in milliseconds, this one was in seconds. This was wrong since #206.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never realized this was wrong, and I guess I kept re-linking as part of my tests, but there was no way for
presagesince a very long time (maybe even forever) to receive messages from a contact that changed their identity (which happens when you change your phone, for example).This PR fixes this and follows the default behavior of official Signal clients.
A
SyncMessageis inserted in the 1-1 thread with the contact whose identity changed, which a client can interpret to display the "Your safety number with [CONTACT] has changed".Currently, the values are used in the following way:
verified::State::Defaultwill always be saved in the timeline when the new identity is savedverified::State::Unverifiedwill be save in the timeline when the safety number changed, letting developers display a warning to users.Note: there is currently no way to manually mark some identity as verified in the timeline, but one could do it manually in a client.
Closes #181