Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't run migration conflict strategy when opening the sled store more than once #228

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Jan 4, 2024

Bubble up any error when running migrations that's not MigrationConflict. We should only apply the migration strategy if we have any unrecoverable error (and leave the choice of what to do to the user).

Fixes boxdot/gurk-rs#261

@gferon gferon enabled auto-merge (squash) January 4, 2024 11:18
@gferon gferon merged commit dac9b35 into main Jan 4, 2024
4 checks passed
@gferon gferon deleted the fix-migration-error-handling branch January 4, 2024 11:22
@gferon gferon restored the fix-migration-error-handling branch February 24, 2024 20:04
@gferon gferon added this to the 0.6.0 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple instances of gurk causes Signal to become de-linked
1 participant