Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contacts from profile #87

Closed
wants to merge 2 commits into from

Conversation

nanu-c
Copy link
Contributor

@nanu-c nanu-c commented Jan 5, 2023

In my case I want to have the username as contact name because i don't know who is who in the contacts list.

@gferon gferon self-requested a review January 6, 2023 08:55
@nanu-c
Copy link
Contributor Author

nanu-c commented Jan 23, 2023

This should be in the manager and not in the cli.

@gferon
Copy link
Collaborator

gferon commented Feb 8, 2023

I'm not sure what the best behavior is here. If you have a contact from your phone, it means that you added somebody to your contacts manually, and I suppose that this should always take precedence over anything. Should we update the actual Contact in the local DB or maintain a RAM cache of profiles we fetch on demand?

@gferon
Copy link
Collaborator

gferon commented Nov 20, 2023

Redone in #211

@gferon gferon closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants