Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit length of PR body to GH maximum #92

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

sergeichestakov
Copy link
Contributor

CI fails if a generated pull request's body exceeds GH's limit. We should prevent this to avoid causing CI to fail in those cases. See Slack thread.

Copy link
Contributor

github-actions bot commented Jun 14, 2024

Unimported Action report

Summary

Project Status Unused Deps Unresolved Deps Unimported Files
packages/action - - -
packages/create-turbo-module - - -
packages/turbo-module - - -

@sergeichestakov sergeichestakov marked this pull request as draft June 15, 2024 21:46
@sergeichestakov
Copy link
Contributor Author

gonna land #93 first / separately so marking this as draft

@sergeichestakov sergeichestakov marked this pull request as ready for review June 17, 2024 17:57
@kodiakhq kodiakhq bot merged commit cefc9e6 into main Jun 17, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the @sergeichestakov/limit-length-body branch June 17, 2024 17:58
kodiakhq bot pushed a commit that referenced this pull request Jun 17, 2024
### General Changes

- Pin eslint version in CI (#93)

### Action Changes

- Limit length of PR body to GH maximum (#92)

### Credits
@sergeichestakov
kodiakhq bot pushed a commit that referenced this pull request Jun 21, 2024
Attempt num 2 since the first time didn't work: #92

CI in apps-monorepo is failing bc the PR body's we generate exceed GH's limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants