Corrected the logic for updating IsEmpty #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2024
Merged
BAndysc
force-pushed
the
isempty_properfix
branch
from
e0c62f0
to
c7f8d5d
Compare
This was referenced Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies the logic for managing the VisibleDockables. The previous code was error prone and in fact there was one typo which caused dockables to randomly disappear (#323). Additionally, the IsEmpty should be also set if there are dockables in the VisibleDockables list, but they are empty. This can happen if all dockables are pinned
Before the fix:
Screen.Recording.2024-03-08.at.02.14.25.mov
After the fix:
Screen.Recording.2024-03-08.at.02.14.46.mov
Before the fix:
Screen.Recording.2024-03-08.at.02.50.21.mov
After the fix (with #322):
Screen.Recording.2024-03-08.at.02.51.48.mov
Fixes: #301, #278, #276