Fix host windows dragging on Windows #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2024
|
I remember that this behavior was different on Windows so EndDrag was needed. Seems like an Avalonia Update changed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why this
EndDrag(e);was there in the first place, it looks like it doesn't serve any purpose. Tested on Windows and macOS and everything works good. TheIsPointerOvercheck is also very wonky in Avalonia - when you drag a host window out of the screen (and keep dragging) and drag the window back - theIsPointerOverstate is lost, even though the mouse is still over the chrome. I don't think the check is needed - the window position changed AND mouseDown conditions are only met if the user is dragging the window, right?Fixes: #319, #315, #302