Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] site survey #707

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[ENH] site survey #707

wants to merge 16 commits into from

Conversation

rksh
Copy link
Contributor

@rksh rksh commented Jul 30, 2024

a sketch of a simple (too simple?) site survey function. WiFi only at first

@uhtu
Copy link
Member

uhtu commented Jul 30, 2024

so what's the workflow with this mode? select nets -> grab everything -> done button -> local trilat -> local kml output?

@uhtu uhtu closed this Jul 30, 2024
@uhtu uhtu reopened this Jul 30, 2024
} else if (rssi >= 70) {
return "#70_to_79";
} else if (rssi >= 60) {
return "#60_to_69";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rksh
Copy link
Contributor Author

rksh commented Jul 30, 2024

so what's the workflow with this mode? select nets -> grab everything -> done button -> local trilat -> local kml output?

Basically, "select a net" from the main list view -> (wait for the DB query to finish before it allows you to do a site survey, unfortch.) -> click the survey button when it's offered -> walk around a bit, staring at your screen like a zombie -> click "end survey" -> get the standard Android "hey, what should I do with this file" dialog and pick how you want get/send your file!

alternately, exit the network activity and go about your business, discarding those observations unwritten or shared.

Copy link
Member

@uhtu uhtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* @author rksh
*/
public class Observation {
private DateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@bobzilladev bobzilladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fun!

@spaetow
Copy link

spaetow commented Jul 31, 2024

Oooooooo, I like it!

Comment on lines 53 to 59
+"<Style id=\"100_and_up\"><IconStyle><color>cc0000ff</color><scale>0.75</scale><Icon> <href>http://maps.google.com/mapfiles/kml/shapes/shaded_dot.png</href></Icon></IconStyle><LabelStyle><scale>0</scale></LabelStyle></Style>"
+"<Style id=\"90_to_99\"><IconStyle><color>cc0055ff</color><scale>0.75</scale><Icon> <href>http://maps.google.com/mapfiles/kml/shapes/shaded_dot.png</href></Icon></IconStyle><LabelStyle><scale>0</scale></LabelStyle></Style>"
+"<Style id=\"80_to_89\"><IconStyle><color>cc00aaff</color><scale>0.75</scale><Icon> <href>http://maps.google.com/mapfiles/kml/shapes/shaded_dot.png</href></Icon></IconStyle><LabelStyle><scale>0</scale></LabelStyle></Style>"
+"<Style id=\"70_to_79\"><IconStyle><color>cc00ffff</color><scale>0.75</scale><Icon> <href>http://maps.google.com/mapfiles/kml/shapes/shaded_dot.png</href></Icon></IconStyle><LabelStyle><scale>0</scale></LabelStyle></Style>"
+"<Style id=\"60_to_69\"><IconStyle><color>cc00ffaa</color><scale>0.75</scale><Icon> <href>http://maps.google.com/mapfiles/kml/shapes/shaded_dot.png</href></Icon></IconStyle><LabelStyle><scale>0</scale></LabelStyle></Style>"
+"<Style id=\"50_to_59\"><IconStyle><color>cc00ff55</color><scale>0.75</scale><Icon> <href>http://maps.google.com/mapfiles/kml/shapes/shaded_dot.png</href></Icon></IconStyle><LabelStyle><scale>0</scale></LabelStyle></Style>"
+"<Style id=\"0_to_49\"><IconStyle><color>cc00ff00</color><scale>0.75</scale><Icon> <href>http://maps.google.com/mapfiles/kml/shapes/shaded_dot.png</href></Icon></IconStyle><LabelStyle><scale>0</scale></LabelStyle></Style>"
Copy link

@wgreenberg wgreenberg Aug 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArcGIS was complaining about the resulting KML file being invalid, and after running it thru a schema validator, looks like it doesn't like these IDs:

element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '100_and_up' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '90_to_99' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '80_to_89' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '70_to_79' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '60_to_69' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '50_to_59' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '40_to_49' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '30_to_39' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '20_to_29' is not a valid value of the atomic type 'xs:ID'.
element Style: Schemas validity error : Element '{http://www.opengis.net/kml/2.2}Style', attribute 'id': '0_to_19' is not a valid value of the atomic type 'xs:ID'.

i think it's just because they start with a non-letter -- if rename them all rssi_90_to_99 etc, it validates just fine!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point - hadn't actually read the spec. fixed in 3e9b800

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortened after seeing the file sizes, but still leading w/ alpha.

@rksh
Copy link
Contributor Author

rksh commented Aug 6, 2024

Strings-ified text and added more. Now to begin the translations!

@rksh rksh removed the do not merge label Aug 8, 2024
@rksh rksh marked this pull request as ready for review August 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants