Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark mode compatibility to Twinkle #2023

Merged
merged 20 commits into from
Nov 6, 2024
Merged

Add dark mode compatibility to Twinkle #2023

merged 20 commits into from
Nov 6, 2024

Conversation

Matr1x-101
Copy link
Contributor

I have tested locally, it seems to work.

@github-actions github-actions bot added Module: morebits The morebits.js library Module: warn Module: twinkle The twinkle.js global gadget file Module: config labels Oct 17, 2024
NovemLinguae
NovemLinguae previously requested changes Oct 17, 2024
View reviewed changes
morebits.js Outdated Show resolved Hide resolved
modules/twinklewarn.js.orig Outdated Show resolved Hide resolved
@NovemLinguae
Copy link
Member

P.S. If you make future pull requests, you should probably do it on a different branch in your repo than master. Can get buggy especially if you do multiple pull requests at the same time.

@NovemLinguae NovemLinguae dismissed their stale review October 17, 2024 20:19

changes completed

siddharthvp
siddharthvp reviewed Oct 19, 2024
View reviewed changes
morebits.css Outdated Show resolved Hide resolved
morebits.css Show resolved Hide resolved
morebits.css Outdated Show resolved Hide resolved
siddharthvp
siddharthvp reviewed Oct 20, 2024
View reviewed changes
morebits.css Outdated Show resolved Hide resolved
morebits.css Show resolved Hide resolved
morebits.css Outdated Show resolved Hide resolved
siddharthvp
siddharthvp reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@siddharthvp siddharthvp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two final issues (other than the unresolved comment above regarding the close button being nearly invisible). Everything else looks good to me.

modules/twinkleblock.js Show resolved Hide resolved
morebits.css Outdated Show resolved Hide resolved
@NovemLinguae NovemLinguae linked an issue Oct 31, 2024 that may be closed by this pull request
Fix issues in Vector 2022 dark mode #1979
Closed
@Matr1x-101
Copy link
Contributor Author

Anything else, or can this be merged @NovemLinguae?

@NovemLinguae
Copy link
Member

@siddharthvp is the better person to review/merge this one since he has been following more closely.

@siddharthvp
Copy link
Member

Looks good to me now. Thanks @Matr1x-101 for persisting through this!

@siddharthvp siddharthvp merged commit 4a07910 into wikimedia-gadgets:master Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthvp siddharthvp siddharthvp left review comments

@NovemLinguae NovemLinguae NovemLinguae left review comments

Assignees
No one assigned
Labels
Module: block Module: config Module: morebits The morebits.js library Module: twinkle The twinkle.js global gadget file Module: warn Module: xfd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix issues in Vector 2022 dark mode
3 participants
@Matr1x-101 @NovemLinguae @siddharthvp