Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunking for API requests #87

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Qwerfjkl
Copy link

Fixes #60, hopefully.

@NovemLinguae
Copy link
Member

NovemLinguae commented Jun 25, 2024

Sadly, Wikimedia is still on ES6 as part of the compatibility policy, and because the gadget minifier is a dinosaur. Async/await is not supported. Can this patch please be refactored to remove await?

Remove dependancy on await
@Qwerfjkl
Copy link
Author

Sadly, Wikimedia is still on ES6 as part of the compatibility policy, and because the gadget minifier is a dinosaur. Async/await is not supported. Can this patch please be refactored to remove await?

Sure, done.

@Qwerfjkl
Copy link
Author

It seems my patch would incidentally fix another, very similar bug:
image
Caused by
image
(the URL in question is this).

@Qwerfjkl
Copy link
Author

Oops, didn't realise the linter was that strict. I've fixed that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-admins cannot close CFDs with more than 50 categories
2 participants