Update Done/cancel buttons

[mazevedofs]

Phabricator: https://phabricator.wikimedia.org/T383460

Notes

• Design review items from the nav bar updates

Test Steps

1. Run the app. Check all the spots mentioned in Robin's comment liked on the task

[tonisevener]

Thanks, these mostly look good, found one regression (commented on appropriate file). I also found some that weren't updated:

For the two factor and change temp, I had to fudge some code to even enter that screen.

I also found one double Done button situation that was missed, we should ask design for instruction here:

Settings > My Languages > Add another language so you have multiple > See Edit button, tap it:

Lastly, there's a series of other pieces of feedback, but they seem a bit more involved due to changing existing X buttons into a label. Maybe we can break that off into a separate task? I would like to prioritize them separately at least, for the chance that they will be deprioritized to a later release.

Article Gallery
Article TOC
Article References
Editor Find in Page

[mazevedofs]

Thanks, these mostly look good, found one regression (commented on appropriate file). I also found some that weren't updated:

Updated those!

Settings > My Languages > Add another language so you have multiple > See Edit button, tap it:

I was a little bold and made the lhs Cancel (since it cancels the actions) and the rhs Done as it applies the changes. I'll run it with Robin on design review as well.

Lastly, there's a series of other pieces of feedback, but they seem a bit more involved due to changing existing X buttons into a label. Maybe we can break that off into a separate task? I would like to prioritize them separately at least, for the chance that they will be deprioritized to a later release.

I chose not to update those here as it goes a little beyond the scope of the cancel/done updates on the new nav bar. I forgot to note it in the description. I'll create a separate ticket for it.

[tonisevener]

Looks good!