Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-1815] Unable to set custom AUTHENTICATION_TIMEOUT value #1708

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lvydra
Copy link
Contributor

@lvydra lvydra commented May 3, 2022

@lvydra
Copy link
Contributor Author

lvydra commented Feb 1, 2023

Hi @fjuma @Skyllarr, could I ask you for a review of this PR?

@ivassile
Copy link
Contributor

@lvydra Can you please change it to target 2.x branch? Thanks!

@lvydra lvydra changed the base branch from 1.x to 2.x January 29, 2024 08:22
@lvydra lvydra requested review from fjuma and Skyllarr as code owners January 29, 2024 08:22
@lvydra
Copy link
Contributor Author

lvydra commented Jan 29, 2024

Hi @ivassile, the base branch should be 2.x now.

Copy link
Contributor

@ivassile ivassile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skyllarr LGTM. Can you also review? Thanks!

@ivassile ivassile added the +1 IV label Feb 6, 2024
@Skyllarr
Copy link
Contributor

Skyllarr commented Feb 27, 2024

@lvydra Can you please rebase this one also? The CI did not run for it yet. If that won't help can you pls try to close it and re-open it ? Otherwise the changes LGTM also

@lvydra
Copy link
Contributor Author

lvydra commented Feb 27, 2024

@Skyllarr rebased

Copy link
Contributor

@Skyllarr Skyllarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lvydra !

@Skyllarr Skyllarr merged commit b80aa6a into wildfly-security:2.x Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants