Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2670] Upgrade org.jboss.slf4j:slf4j-jboss-logmanager from 1.0.4.GA to 1.2.0.Final #2054

Merged
merged 2 commits into from
Dec 11, 2023
Merged

[ELY-2670] Upgrade org.jboss.slf4j:slf4j-jboss-logmanager from 1.0.4.GA to 1.2.0.Final #2054

merged 2 commits into from
Dec 11, 2023

Conversation

areebniyas
Copy link
Contributor

PrarthonaPaul
PrarthonaPaul approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @areebniyas

@Skyllarr Skyllarr mentioned this pull request Oct 27, 2023
Closed
@PrarthonaPaul
Copy link
Contributor

Hi @areebniyas
It seems that this branch is conflicting with the main branch.
Would you be able to rebase and resolve the conflicts? If you have any questions about how to do this, please feel free to let me know :)
Thanks!

@areebniyas
Copy link
Contributor Author

Resolved the conflict, let me know if it looks okay @PrarthonaPaul

@PrarthonaPaul
Copy link
Contributor

Looks good.
Thanks @areebniyas

@fjuma fjuma merged commit 1a12edc into wildfly-security:2.x Dec 11, 2023
3 checks passed
@fjuma fjuma added the +1 FJ label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrarthonaPaul PrarthonaPaul PrarthonaPaul approved these changes

@Skyllarr Skyllarr Skyllarr approved these changes

@fjuma fjuma Awaiting requested review from fjuma fjuma is a code owner

Assignees
No one assigned
Labels
hacktoberfest-accepted +1 DV +1 FJ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@areebniyas @PrarthonaPaul @Skyllarr @fjuma