Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2639] Add a test for MaskCommand.decryptMasked method #2092

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[ELY-2639] Add a test for MaskCommand.decryptMasked method #2092

merged 1 commit into from
Feb 28, 2024

Conversation

xjusko
Copy link
Contributor

@xjusko xjusko commented Feb 7, 2024

@xjusko xjusko requested review from fjuma and Skyllarr as code owners February 7, 2024 08:37
@xjusko
Copy link
Contributor Author

xjusko commented Feb 12, 2024

Not sure why CI failed, all tests passed on my machine and the tests that failed in CI don't seem to have any connection to my changes.

@fjuma
Copy link
Contributor

fjuma commented Feb 12, 2024

@xjusko I've re-triggered CI.

@xjusko
Copy link
Contributor Author

xjusko commented Feb 22, 2024

Hi @fjuma, I believe the CI failing has nothing to do with my changes. Could you look at it, please?

fjuma
fjuma approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xjusko! The changes look good, the failures were indeed unrelated, looks like we might have been hitting an issue with the CI environment. I've re-triggered CI again.

@ivassile ivassile added the +1 IV label Feb 27, 2024
@Skyllarr Skyllarr merged commit 5ecf106 into wildfly-security:2.x Feb 28, 2024
3 checks passed
@Skyllarr
Copy link
Contributor

Thanks @xjusko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjuma fjuma fjuma approved these changes

@ivassile ivassile ivassile approved these changes

@Skyllarr Skyllarr Awaiting requested review from Skyllarr Skyllarr is a code owner

Assignees
No one assigned
Labels
+1 IV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xjusko @fjuma @Skyllarr @ivassile