Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-18461] cmt Quickstart Common Enhancements CY2023Q3 #731

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[WFLY-18461] cmt Quickstart Common Enhancements CY2023Q3 #731

merged 1 commit into from
Oct 16, 2023

Conversation

marcosgopen
Copy link
Contributor

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

Hi @marcosgopen. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

emmartins
emmartins requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the pointed changes please also change runtimeName at https://github.com/wildfly/quickstart/pull/731/files#diff-2013e1734bf0fce09cc1ce9a533ea791cc7e3737fcd82b8d8a0d85fc1caff0efL234 , to name. As shown now at https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.ob4izb19fxpk

.github/workflows/quickstart_cmt_ci.yml Outdated
uses: ./.github/workflows/quickstart_ci.yml
with:
QUICKSTART_PATH: cmt
MICROPROFILE: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To further enhance the customization and add extensions points there were changes done https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.c4iuyi3bm84h
In this case please change this to TEST_PROVISIONED_SERVER: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I 've just replaced MICROPROFILE: false with TEST_PROVISIONED_SERVER: true

cmt/pom.xml Outdated
</configuration>
<executions>
<execution>
<goals>
<goal>integration-test</goal>
<goal>verify</goal>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the verify goal, it was a bug in the doc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've just fixed it.

@marcosgopen
Copy link
Contributor Author

marcosgopen commented Oct 16, 2023 •
edited
Loading

Besides the pointed changes please also change runtimeName at https://github.com/wildfly/quickstart/pull/731/files#diff-2013e1734bf0fce09cc1ce9a533ea791cc7e3737fcd82b8d8a0d85fc1caff0efL234 , to name. As shown now at https://docs.google.com/document/d/1GFnZrnlwRkwC0HfziRws2UUWR99KdaQayA7Ei12SGN4/edit#heading=h.ob4izb19fxpk

Thanks @emmartins , I addressed your review.

@emmartins
Copy link
Contributor

/ok-to-test

@emmartins emmartins self-requested a review October 16, 2023 14:55
emmartins
emmartins approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @marcosgopen, all looks good to me

@emmartins
Copy link
Contributor

@kabir FYI this one is ready for OpenShift testing too

@emmartins emmartins merged commit 056004e into wildfly:main Oct 16, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmartins emmartins emmartins approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosgopen @emmartins