handle empty strings. closes #5.

wilkelab · Feb 3, 2020 · 6746a9e · 6746a9e
1 parent 351d539
commit 6746a9e
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,6 @@
 # gridtext devel
 
-Nothing done yet.
+- `richtext_grob()` and `textbox_grob()` now gracefully handle empty strings.
 
 # gridtext 0.1.0
 

diff --git a/R/richtext-grob.R b/R/richtext-grob.R
@@ -222,7 +222,7 @@ make_inner_box <- function(text, halign, valign, use_markdown, gp) {
   if (use_markdown) {
     text <- markdown::markdownToHTML(text = text, options = c("use_xhtml", "fragment_only"))
   }
-  doctree <- read_html(text)
+  doctree <- read_html(paste0("<!DOCTYPE html>", text))
 
   drawing_context <- setup_context(gp = gp, halign = halign, word_wrap = FALSE)
   boxlist <- process_tags(xml2::as_list(doctree)$html$body, drawing_context)

diff --git a/R/textbox-grob.R b/R/textbox-grob.R
@@ -236,7 +236,7 @@ textbox_grob <- function(text, x = NULL, y = NULL,
   if (use_markdown) {
     text <- markdown::markdownToHTML(text = text, options = c("use_xhtml", "fragment_only"))
   }
-  doctree <- read_html(text)
+  doctree <- read_html(paste0("<!DOCTYPE html>", text))
 
   # if width is set to NULL, we use the native size policy and turn off word wrap
   if (is.null(width)) {

diff --git a/tests/testthat/test-richtext-grob.R b/tests/testthat/test-richtext-grob.R
@@ -79,6 +79,12 @@ test_that("grobheight and grobwidth work", {
   expect_equal(h1, h2)
 })
 
+test_that("misc. tests", {
+  # empty strings work
+  expect_silent(richtext_grob(""))
+  expect_silent(richtext_grob(" "))
+})
+
 test_that("visual tests", {
   draw_labels <- function() {
     function() {

diff --git a/tests/testthat/test-textbox-grob.R b/tests/testthat/test-textbox-grob.R
@@ -1,5 +1,11 @@
 context("textbox grob")
 
+test_that("misc. tests", {
+  # empty strings work
+  expect_silent(textbox_grob(""))
+  expect_silent(textbox_grob(" "))
+})
+
 test_that("visual tests", {
   draw_box <- function() {
     function() {