accept proposed changes from review

wilkelab · Apr 22, 2022 · 82a0b13 · 82a0b13
1 parent b410f97
commit 82a0b13
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/R/drawing-context.R b/R/drawing-context.R
@@ -70,13 +70,13 @@ set_context_gp <- function(drawing_context, gp = NULL) {
 
 # update the fontface of a drawing context
 set_context_fontface <- function(drawing_context, fontface = "plain", overwrite = FALSE) {
-  fontface_old <- drawing_context$gp$font
+  font_old <- drawing_context$gp$font
 
   # combine bold and italic if needed
   if (!isTRUE(overwrite)) {
-    if (isTRUE(fontface == "italic") && isTRUE(fontface_old == 2)) { # see ?grid::gpar for fontface codes
+    if (isTRUE(fontface == "italic") && isTRUE(font_old == 2)) { # see ?grid::gpar for fontface codes
       fontface <- "bold.italic"
-    } else if (isTRUE(fontface == "bold") && isTRUE(fontface_old == 3)) {
+    } else if (isTRUE(fontface == "bold") && isTRUE(font_old == 3)) {
       fontface <- "bold.italic"
     }
   }

diff --git a/R/text-details.R b/R/text-details.R
@@ -2,14 +2,14 @@
 #'
 #' Calculate text details for a given text label
 #' @param label Character vector containing the label. Can handle only one label at a time.
-#' @param gp Grid graphical parameters defining the font (`fontfamily`, `font`, and
+#' @param gp Grid graphical parameters defining the font (`fontfamily`, `fontface`, and
 #'   `fontsize` should be defined).
 #' @examples
-#' text_details("Hello world!", grid::gpar(fontfamily = "", font = "plain", fontsize = 12))
-#' text_details("Hello world!", grid::gpar(fontfamily = "", font = "plain", fontsize = 24))
+#' text_details("Hello world!", grid::gpar(fontfamily = "", fontface = "plain", fontsize = 12))
+#' text_details("Hello world!", grid::gpar(fontfamily = "", fontface = "plain", fontsize = 24))
 #' text_details(
 #'   "Hello world\nwith newline",
-#'   grid::gpar(fontfamily = "", font = "plain", fontsize = 12)
+#'   grid::gpar(fontfamily = "", fontface = "plain", fontsize = 12)
 #' )
 #' @noRd
 text_details <- function(label, gp = gpar()) {