-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise PHPStan level to 2 #58
base: master
Are you sure you want to change the base?
Conversation
Yes, many return types are interfaces, not concrete implementations. But there are exceptions 🤯
|
Let me pull out my secret laser gun 🔫 wordpress-interop/test/Test/Bridge/Repository/TermRepositoryTest.php Lines 21 to 22 in b8e5fff
|
Errors on Level 2 reduced from 140 to 51 🎉 Supporting RepositoryClass attribute: phpstan/phpstan#9279 I do not know how to go on as there is no mechanism in PHPStan ... although one can write a tiny type specifying extension. |
The above so called "PHPStan extension" finds out Repository names using |
@williarin Could you help fixing remaining ones? |
Under level 4 👺 viktor says: broken application/package
(not polite)