fix: Review and update service units and socket unit to include distribution defaults #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
force-pushed
the
runtime
branch
4 times, most recently
from
fe17829 to
91a2770
Compare
Jakuje
changed the title
Jakuje
force-pushed
the
runtime
branch
2 times, most recently
from
1351d2e to
2e3e67f
Compare
richm
reviewed
Nov 27, 2023
richm
reviewed
Nov 27, 2023
richm
reviewed
Nov 27, 2023
richm
reviewed
Nov 27, 2023
|
@richm @mattwillsher is this ready to merge or is there some more work needed and I should pull the changes fixing CI into separate PR? |
mattwillsher
approved these changes
Jan 22, 2024
|
Looks ok to me from a cursory review |
richm
reviewed
Jan 22, 2024
richm
approved these changes
Jan 22, 2024
|
I guess ansible-lint still has the bug where it will not check multiline |
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Specifics: * Debian 12 has no longer the instantiated service using inet, see the following commit: https://salsa.debian.org/ssh-team/openssh/-/commit/0dc73888bbfc17fae04b891ac0c80f35f9c44f48 * I am not matching the Description tag verbosely as I do not find it crucial for functionality. * We generate additional -f switch to the sshd CLI pointing go the main sshd config we manage * The Before=sshd.service in the socket is not generated as I find it unnecessary when we conflict the service. * Recent Ubuntu versions have RuntimeDirectoryPreserve option, which I set for all Ubuntu/Debian as it should not hurt. Signed-off-by: Jakub Jelen <[email protected]>
…nt options Signed-off-by: Jakub Jelen <[email protected]>
|
So it looks like its final, green and ready to merge, unless there will be some more comments. I did similar change regarding the After keyword also in the instantiated service file. |
ok - still lgtm |
|
ready to merge? |
|
Fine with me.
…On Thu, Jan 25, 2024 at 7:16 PM Richard Megginson ***@***.***> wrote:
ready to merge?
—
Reply to this email directly, view it on GitHub
<#267 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUR2WM7XCPEWOEWO2K3FJ3YQKOOPAVCNFSM6AAAAAA6WNNCQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQG42DEOBZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Update systemd units to reflect OS defaults
Reason: The systemd units were based on some old ubuntu/debian and never updated to match current versions.
Result: The generated units include all important system defaults
Issue Tracker Tickets (Jira or BZ if any): -