fix: Fix service files generated on EL7 and workaround the tests for containers #276
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vinit' in containers Signed-off-by: Jakub Jelen <[email protected]>
note, that this is not the case for the instantiated, which is in sync with everything else. Signed-off-by: Jakub Jelen <[email protected]>
richm
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: The service files on EL7 are generated with original content.
Reason: The centos7 containers report
ansible_facts["service_mgr"] = "sysvinit"which lead to skipping this test in the upstream CI. The CentOS7 is also the only OS that defines the environment file as a mandatory (missing the-sign in front of the filename), which caused the downstream tests executed against VMs to fail. But only in the mainsshd.service. The minus sign is present in the instantiated[email protected]to add even more confusionResult: The role should generate original service files.
Issue Tracker Tickets (Jira or BZ if any): -
The diff in the generated
sshd.servicefile before this change should be limited to the following change: