feat: New options in OpenSSH + fixes for bugx in OpenSSH 9.9p1 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Jelen <[email protected]>
mattwillsher
approved these changes
Dec 16, 2024
Jakuje
force-pushed
the
openssh-options
branch
from
5fe8557 to
7cc5fd0
Compare
|
Still trying to fiddle with the CI to unbreak the Fedora. |
|
Filled the RFE for CentOS 10 in roles-ansible/check-ansible-centos-centos9-action#3 (for now using my fork) and for Fedora in roles-ansible/check-ansible-fedora-latest-action#5 (for now using my fork in this PR). This is ready for reviews. We can merge it as it is and then revert the CI changes when we will have the GH actions updated or wait. Adding also @richm who asked for this workaround initially to review the changes. |
richm
approved these changes
Dec 16, 2024
Jakuje
force-pushed
the
openssh-options
branch
from
7cc5fd0 to
4828f8a
Compare
Signed-off-by: Jakub Jelen <[email protected]>
The OpenSSH 9.9p1 has a bug in parsing/printing the Compression option so lets use different option for testing. https://bugzilla.mindrot.org/show_bug.cgi?id=3759 Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
force-pushed
the
openssh-options
branch
from
4828f8a to
1e602d9
Compare
|
The changes to the GH actions were merged so this is ready to merge now when you are ready. |
Jakuje
added a commit
to Jakuje/ssh
that referenced
this pull request
Jan 8, 2025
This was reported upstream and fixed: https://bugzilla.mindrot.org/show_bug.cgi?id=3759 But the compression is something we do not want to use anyway much so implementing this workaround similar to the one we did in the server role: willshersystems/ansible-sshd#304 Signed-off-by: Jakub Jelen <[email protected]>
Jakuje
added a commit
to Jakuje/ssh
that referenced
this pull request
Jan 8, 2025
This was reported upstream and fixed: https://bugzilla.mindrot.org/show_bug.cgi?id=3759 But the compression is something we do not want to use anyway much so implementing this workaround similar to the one we did in the server role: willshersystems/ansible-sshd#304 Signed-off-by: Jakub Jelen <[email protected]>
richm
pushed a commit
to linux-system-roles/ssh
that referenced
this pull request
Jan 8, 2025
This was reported upstream and fixed: https://bugzilla.mindrot.org/show_bug.cgi?id=3759 But the compression is something we do not want to use anyway much so implementing this workaround similar to the one we did in the server role: willshersystems/ansible-sshd#304 Signed-off-by: Jakub Jelen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Tracker Tickets (Jira or BZ if any): RHEL-68346 (workaround)