fix: ensure all extensions calls are made to canIndex()

wilr · Feb 10, 2022 · c8f47ac · c8f47ac
1 parent f786648
commit c8f47ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Jobs/AlgoliaIndexItemJob.php b/src/Jobs/AlgoliaIndexItemJob.php
@@ -97,7 +97,7 @@ public function process()
 
         if (!$obj) {
             $this->addMessage('Record #'. $id . ' not found');
-        } elseif (!$obj->canIndexInAlgolia()) {
+        } elseif (min($obj->invokeWithExtensions('canIndexInAlgolia')) === false) {
             $this->addMessage('Record #'. $id .' not indexed, canIndexInAlgolia returned false');
         } else {
             if (!$obj->AlgoliaUUID) {

diff --git a/src/Tasks/AlgoliaReindex.php b/src/Tasks/AlgoliaReindex.php
@@ -137,7 +137,7 @@ public function indexItem($obj = null): bool
     {
         if (!$obj) {
             return false;
-        } elseif (!$obj->canIndexInAlgolia()) {
+        } elseif (min($obj->invokeWithExtensions('canIndexInAlgolia')) === false) {
             return false;
         } else {
             if (!$obj->AlgoliaUUID) {
@@ -208,7 +208,7 @@ public function indexItems($targetClass, $filter = '', $items = null, $output =
                 // fetch the actual instance
                 $instance = DataObject::get_by_id($item->ClassName, $item->ID);
 
-                if (!$instance || !$instance->canIndexInAlgolia()) {
+                if (!$instance || min($instance->invokeWithExtensions('canIndexInAlgolia')) == false) {
                     $skipped++;
 
                     continue;