fix: don't sync settings on dev/build

wilr · Sep 2, 2024 · ec0590c · ec0590c
1 parent a3c286a
commit ec0590c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 23 deletions.
diff --git a/src/Extensions/AlgoliaObjectExtension.php b/src/Extensions/AlgoliaObjectExtension.php
@@ -19,6 +19,7 @@
 use Wilr\Silverstripe\Algolia\Jobs\AlgoliaIndexItemJob;
 use Wilr\SilverStripe\Algolia\Service\AlgoliaIndexer;
 use Wilr\SilverStripe\Algolia\Service\AlgoliaService;
+use Wilr\SilverStripe\Algolia\Tasks\AlgoliaConfigure;
 
 class AlgoliaObjectExtension extends DataExtension
 {
@@ -87,29 +88,6 @@ public function updateSettingsFields(FieldList $fields)
         }
     }
 
-    /**
-     * On dev/build ensure that the indexer settings are up to date.
-     */
-    public function requireDefaultRecords()
-    {
-        if ($this->ranSync) {
-            return false;
-        }
-
-        $this->ranSync = true;
-        $algolia = Injector::inst()->create(AlgoliaService::class);
-
-        if (!$this->indexEnabled()) {
-            return;
-        }
-
-        try {
-            $algolia->syncSettings();
-        } catch (Throwable $e) {
-            DB::alteration_message($e->getMessage(), 'error');
-        }
-    }
-
     /**
      * Returns whether this object should be indexed into Algolia.
      */

diff --git a/src/Tasks/AlgoliaConfigure.php b/src/Tasks/AlgoliaConfigure.php
@@ -24,6 +24,11 @@ public function run($request)
     {
         $service = Injector::inst()->get(AlgoliaService::class);
 
+        if (!$this->isEnabled()) {
+            echo 'This task is disabled.' . PHP_EOL;
+            return;
+        }
+
         try {
             if ($service->syncSettings()) {
                 echo 'Success.' . PHP_EOL;