Add option to create a Kubernetes secret containing the databaseUrl #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgarlis
commented
Jan 30, 2025
| @@ -51,7 +51,13 @@ spec: | |||
| {{- with .Values.hub.extraEnv }} | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{ if .Values.hub.databaseUrlSecretName }} | |||
| {{ if .Values.hub.databaseSecret }} | |||
There was a problem hiding this comment.
Not a user of those values but I assumed that it would also be needed here for consistency
nickgarlis
commented
Jan 30, 2025
| @@ -70,7 +70,13 @@ spec: | |||
| - name : "METRICS_ADDR" | |||
| value: "true" | |||
| {{ end }} | |||
| {{ if .Values.windmill.databaseUrlSecretName }} | |||
| {{- if and .Values.windmill.createSecret .Values.windmill.databaseUrl -}} | |||
There was a problem hiding this comment.
I decided to go this way for backwards compatibility reasons and to not enforce the secret creation to those that don't use it.
nickgarlis
force-pushed
the
add-database-secret-option
branch
from
875a06f to
23209bb
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to create a Kubernetes secret with the name
windmill-databasecontaining the value ofwindmill.databaseUrlif the optionwindmill.databaseSecretistrue.If this is of interest and you would require changes then I'd be happy to make them.