Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: duckdb connection settings with azure blob storage #5180

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Jan 30, 2025

Important

Add azure_container_path to DuckDB connection settings and remove unused import in users.rs.

  • API Changes:
    • Added azure_container_path field to openapi.yaml for DuckDB connection settings.
  • Code Cleanup:
    • Removed unused import BASE_URL from users.rs.

This description was created by Ellipsis for 4c2716b. It will automatically update as commits are pushed.

@alpetric alpetric requested a review from rubenfiszel as a code owner January 30, 2025 20:52
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 270bc8e in 9 seconds

More details
  • Looked at 20 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/windmill-api/openapi.yaml:10117
  • Draft comment:
    Consider adding a description for azure_container_path to improve API documentation clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of azure_container_path in the openapi.yaml file should also include a description for better API documentation.

Workflow ID: wflow_TZlcLx9a00Edkv4v


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e2989e
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4c2716b in 12 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/windmill-api/src/users.rs:49
  • Draft comment:
    The removal of the BASE_URL import is appropriate as it is not used in this file.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The removal of the BASE_URL import seems intentional and correct, as it is not used anywhere in the file.

Workflow ID: wflow_UKxSnCiTRnxfrIaj


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit 8ba0f3a into main Jan 30, 2025
2 of 3 checks passed
@rubenfiszel rubenfiszel deleted the alp/duckdb_azure branch January 30, 2025 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants