Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix worker restart on otel setting set from undefined to null #5183

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

pyranota
Copy link
Collaborator

@pyranota pyranota commented Jan 31, 2025

Important

Add migrations to handle 'otel' setting in global_settings to fix worker restart issue.

  • Migrations:
    • Add 20250131115248_otel_global_settings.up.sql to insert 'otel' setting into global_settings.
    • Add 20250131115248_otel_global_settings.down.sql to delete 'otel' setting from global_settings.

This description was created by Ellipsis for d7098f8. It will automatically update as commits are pushed.

@pyranota pyranota requested a review from rubenfiszel as a code owner January 31, 2025 12:02
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d7098f8 in 15 seconds

More details
  • Looked at 14 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. backend/migrations/20250131115248_otel_global_settings.down.sql:1
  • Draft comment:
    Add a newline at the end of the file to follow POSIX standards.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The migration files should include a newline at the end of the file to follow POSIX standards and avoid potential issues with some tools.
2. backend/migrations/20250131115248_otel_global_settings.up.sql:1
  • Draft comment:
    Add a newline at the end of the file to follow POSIX standards.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The migration files should include a newline at the end of the file to follow POSIX standards and avoid potential issues with some tools.

Workflow ID: wflow_dFj6Aua2B3XJygOa


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: d7098f8
Status: ✅  Deploy successful!
Preview URL: https://20b73c38.windmill.pages.dev
Branch Preview URL: https://no-restart-otel.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 940fb03 into main Jan 31, 2025
7 checks passed
@rubenfiszel rubenfiszel deleted the no-restart-otel branch January 31, 2025 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants