feat(python): make S3 cache arch specific

[pyranota]

Current schema:

New schema:

---

Important

Make S3 cache paths architecture-specific and adjust logging level in uv_pip_compile.

• Behavior:
  • Introduces TARGET constant in global_cache.rs to make S3 cache paths architecture-specific.
  • Updates paths in build_tar_and_push and pull_from_tar to include TARGET.
• Logging:
  • Changes logging level from error to debug in uv_pip_compile in python_executor.rs.

^{This description was created by for dfc7f12. It will automatically update as commits are pushed.}

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	dfc7f12
Status:	✅  Deploy successful!
Preview URL:	https://a618a76e.windmill.pages.dev
Branch Preview URL:	https://py-multiarch-s3-cache.windmill.pages.dev

View logs

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to dfc7f12 in 1 minute and 50 seconds

More details

• Looked at 45 lines of code in 2 files
• Skipped 1 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. backend/windmill-worker/src/global_cache.rs:62

• Draft comment:
  Consider using named parameters for clarity in the S3 path. The format string "/tar/{TARGET}/{}/{folder_name}.tar" relies on auto-captured identifiers (TARGET and folder_name) along with a positional placeholder. Explicitly naming all parameters (e.g. using "{target}", "{python}", "{folder_name}") can improve readability and reduce potential bugs.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  While named parameters can improve readability, this case is fairly straightforward. The format string is short and the meaning is clear from context. The positional parameter comes from an inline if expression, making it natural to use a positional parameter. The code is consistent in both places it appears. No real risk of bugs since the format is simple.
  The comment does identify a real coding practice issue. Named parameters can make code more maintainable in the long run.
  However, this is a minor stylistic suggestion that doesn't materially improve the code quality or reduce bug risk in this specific case. The current format is clear and consistent.
  Delete this comment as it suggests a minor stylistic change that doesn't meaningfully improve the code quality or reduce bugs in this specific case.

2. backend/windmill-worker/src/python_executor.rs:635

• Draft comment:
  Changing log level from 'error' to 'debug' for uv args is a good improvement to reduce noise in production logs.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

3. backend/windmill-worker/src/global_cache.rs:62

• Draft comment:
  Using {TARGET} in the S3 key path now makes caching arch-specific. Ensure that TARGET is computed correctly across all platforms (consider including OS if needed).
• Reason this comment was not posted:
  Comment did not seem useful.

4. backend/windmill-worker/src/python_executor.rs:635

• Draft comment:
  Changed uv args logging from error to debug to reduce noise. This is appropriate if the log is not indicating an error.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_FFCIZzVPtmEzkybM

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.