Prepare vs17 library builds #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2024
Merged
cmb69
force-pushed
the
cmb/vs17
branch
2 times, most recently
from
584006b to
e394ba6
Compare
We make the necessary additions to `compute-virtuals.ps1`, where the choice of the WinSDK is somewhat arbitrary but rather conservative.
This is needed to actually be able to do vs17 builds, since that requires Visual Studio 2022, which is not available on the windows- 2019 runners. That implies that vc15 builds are no longer possible without additional changes[1], but that shouldn't be a concern because none of the supported PHP versions require vc15 builds. [1] <actions/runner-images#9701>
Since window-2022 uses Visual Studio 2022, we need to update the CMake generators; using the proper toolset is already catered to by the `-T` option.
Windows SDK 10.0.18362.0 is not available on windows-2022 runners.
This solves the stdalign.h issue for ICU 75.1.
|
While I have not been able to thoroughly test this, I'm marking the PR as ready for review, since there is not much time until PHP 8.4.0 goes into RC stage, and we should probably rebuilt all dependencies with vs17. An alternative to switching to windows-2022 runners would be to take the version (2019 vs. 2022) as input argument, and to remove the PHP version input for those workflows which don't need dependencies (for the others we would need to ask for both runner version and PHP version). Note that there is some overlap with PR #9; especially which Windows SDK versions to use is something to consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to do vs17 (aka. Visual Studio 2022) builds, we need to switch to
windows-2022runners (or would need to install that VS version onwindows-2019). Instead of using either runners, we usewindows-2022for vs17 and as well as vs16 builds, what shouldn't be a problem, and solves the potential issue thatwindows-2019runners may not provided until end of 2027 (where we still may have to build PHP 8.3 dependencies).windows-2022runners do no longer support vc15 by default, but that shouldn't be a problem, since none of the supported PHP versions need vc15 builds.Note that this is barely tested yet, thus I'm submitting this as draft PR.