refactor(core): move actions inside core

[ematipico]

Changes

This PR moves actions inside core. Actions are now part of the pipeline, and they are loaded in the same way the middleware is loaded:

• using ModuleLoader in development
• using its entry point after the first build
• using its moduleId when build for SSR

The internal virtual module of the actions is in charge of emitting a stub of the actions in case the user doesn't have any.

The injections of the actions during development is done inside the route.ts. I decided to do it there because I wanted to assume that the actions must be already loaded when creating the RenderContext, which is our agnostic runtime renderer. Because fo that, the Pipeline class also exposes a method called setActions.

Testing

Current tests and functionality should stay the same. The Actions middleware was already set to be the last one, which is the same as we just moved inside the lastNext callback we have in core.

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: 126ec8a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[florian-lefebvre]

Although this is a refactor, maybe should we have a changeset to be safe in case people face issues

[codspeed-hq]

CodSpeed Performance Report

Merging #13262 will not alter performance

_{Comparing refactor/astro-actions (b003bac) with main (2e1321e)}

Summary

✅ 6 untouched benchmarks

[ematipico]

Turns out it is not as simple as that, it requires a full refactor of the architecture. I'll see to that

Outdated

[ematipico]

I checked the e2e test that failed, and the issue isn't much clear. The db package fails to run the seed file, however it doesn't happen when I run the dev server for the fixture.

Also, when running the fixture locally, the likes action (the action) works as expected, but the query doesn't return the expected data. This doesn't happen for the comments action.

As for now, I commented on them.

[bholmesdev]

Just noting that if this is required, it's a user-side bug. Understand if this is just a debug in-progress

[ematipico]

That's intentional. For some reason, the toString() isn't called anymore. Has something changed in the TSX compiler? I bet that if we use a template literal, the toString() function is called, however... like this, toString() isn't automatically called, so I am afraid the transformation is doing something fishy

[bholmesdev]

Nice, this looks like the fix we needed.

And I'll add some context from @JacobNWolf 's issue to make sure we test it: Actions were being bundled into edge middleware, when they should only be bundled into your server runtime. It looks like this moves the functionality into the server runtime, but I wanna make sure we make a test project (ideally a fixture) that confirms actions aren't bundled into middleware by accident still.

[JacobNWolf]

Amazing. Thank you guys.

[pkg-pr-new]

astro

npm i https://pkg.pr.new/astro@13262

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13262

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13262

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13262

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13262

commit: 126ec8a

[ematipico]

@JacobNWolf, can you please use the latest preview release and see if that fixes your issue?