fix(core): double encoding during match of routes

.changeset/stale-oranges-call.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes an issue where the dev server was applying second decoding of the URL of the incoming request, causing issues for certain URLs.

packages/astro/src/core/app/index.ts

@@ -177,7 +177,7 @@ export class App {
 		if (!pathname) {
 			pathname = prependForwardSlash(this.removeBase(url.pathname));
 		}
-		let routeData = matchRoute(pathname, this.#manifestData);
+		let routeData = matchRoute(decodeURI(pathname), this.#manifestData);
 
 		// missing routes fall-through, pre rendered are handled by static layer
 		if (!routeData || routeData.prerender) return undefined;

packages/astro/src/core/build/generate.ts

@@ -360,7 +360,7 @@ async function getPathsForRoute(
 				// NOTE: The same URL may match multiple routes in the manifest.
 				// Routing priority needs to be verified here for any duplicate
 				// paths to ensure routing priority rules are enforced in the final build.
-				const matchedRoute = matchRoute(staticPath, options.routesList);
+				const matchedRoute = matchRoute(decodeURI(staticPath), options.routesList);
 				return matchedRoute === route;
 			});
 

packages/astro/src/core/routing/match.ts

@@ -5,18 +5,17 @@ import { SERVER_ISLAND_BASE_PREFIX, SERVER_ISLAND_COMPONENT } from '../server-is
 
 /** Find matching route from pathname */
 export function matchRoute(pathname: string, manifest: RoutesList): RouteData | undefined {
-	const decodedPathname = decodeURI(pathname);
 	return manifest.routes.find((route) => {
 		return (
-			route.pattern.test(decodedPathname) ||
-			route.fallbackRoutes.some((fallbackRoute) => fallbackRoute.pattern.test(decodedPathname))
+			route.pattern.test(pathname) ||
+			route.fallbackRoutes.some((fallbackRoute) => fallbackRoute.pattern.test(pathname))
 		);
 	});
 }
 
 /** Finds all matching routes from pathname */
 export function matchAllRoutes(pathname: string, manifest: RoutesList): RouteData[] {
-	return manifest.routes.filter((route) => route.pattern.test(decodeURI(pathname)));
+	return manifest.routes.filter((route) => route.pattern.test(pathname));
 }
 
 const ROUTE404_RE = /^\/404\/?$/;

packages/astro/test/fixtures/ssr-params/src/pages/d/[slug].astro

@@ -0,0 +1,9 @@
+---
+export const prerender = false;
+export function getStaticPaths() {
+	return [
+		{ params: { slug: `_'"()&%` } },
+	]
+}
+---
+<h1>Hello {Astro.url} </h1>

packages/astro/test/params.test.js

@@ -113,6 +113,20 @@
 		const $ = cheerio.load(html);
 		assert.equal($('.category').text(), '你好');
 	});
+
+	it('should not decode twice', async () => {
+		try {
+			await fixture
+				.fetch(
+					"/d/_'%22()&%25",
+				)
+				.then((res) => res.text());
+			assert.ok(true);
+		} catch (e) {
+			console.log(e);
+			assert.fail('Should not throw an error: ' + e.message);
+		}
+	});
 });
 
 describe('Astro.params in static mode', () => {