-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing server context from cloudflare example #10913
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Thanks for this @robmen ! I suspect this is exactly the change needed, but I'll tag @florian-lefebvre in to also confirm whether we should be updating this reference page/example so that we're always importing from either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks!
Yes the reference should be updated too, to use |
Thanks Florian! @robmen Would you be able to also add the change to the reference page I linked above in my last comment? |
Description (required)
The Cloudflare example using
astro;env
did not work because it was missing the context. Adding/server
fixed it for me, so I thought I'd send the change your way. If there is a better fix, please feel free to close this PR with a better one. 😄Related issues & labels (optional)