Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing server context from cloudflare example #10913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robmen
Copy link

@robmen robmen commented Feb 7, 2025

Description (required)

The Cloudflare example using astro;env did not work because it was missing the context. Adding /server fixed it for me, so I thought I'd send the change your way. If there is a better fix, please feel free to close this PR with a better one. 😄

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7c1b838
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67a611b33afdf90008aa69f4
😎 Deploy Preview https://deploy-preview-10913--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/environment-variables.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918
Copy link
Member

Thanks for this @robmen ! I suspect this is exactly the change needed, but I'll tag @florian-lefebvre in to also confirm whether we should be updating this reference page/example so that we're always importing from either /client or /server everywhere we show it!

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@florian-lefebvre
Copy link
Member

florian-lefebvre commented Feb 7, 2025

Yes the reference should be updated too, to use astro:env/server

@sarah11918
Copy link
Member

Thanks Florian!

@robmen Would you be able to also add the change to the reference page I linked above in my last comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants