-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate: replace deprecated output: server refrence with SSR #10942
base: main
Are you sure you want to change the base?
Conversation
as of astro 5, the output: server is optional and not needed
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Keshav! Thank you for finding this one... we've been trying to "catch them all" and replace them, but some keep slipping through. 😄
One issue with making this change, though, is that the rest of the page assumes output: 'server'
and therefore this guide would not work as intended without it.
All the routes would be server-rendered by default in this guide, so you would never need to say export const prerender = false
to make this guide work. If you remove the server
requirement, then this whole page needs to be checked and the line of code to prevent prerendering needs to be added to all the example files that do need to be server rendered.
So, if you'd like to continue with this change (which I think is a good one!), then you'll need to check the entire guide carefully, because it was written specifically for output: 'server'
and this entire guide assumes routes will NOT be prerendered by default. Are you still interested in continuing with this?
Co-authored-by: Sarah Rainsberger <[email protected]>
as of astro 5, the output: server is optional and not needed
Description (required)
So, the firebase and astro getting started documentation says that you need a astro project with config output: "server" which is no longer needed as of astro 5. so removing it to not cause any confusion for future readers
Just replaced the output:"server" refrence in the top of the document to point to "SSR" enabled project instead
discord: gdm_music