Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate: replace deprecated output: server refrence with SSR #10942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Keshav-writes-code
Copy link

as of astro 5, the output: server is optional and not needed

Description (required)

So, the firebase and astro getting started documentation says that you need a astro project with config output: "server" which is no longer needed as of astro 5. so removing it to not cause any confusion for future readers

Just replaced the output:"server" refrence in the top of the document to point to "SSR" enabled project instead

discord: gdm_music

as of astro 5, the output: server is optional and not needed
Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ea03b77
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67ac059bdc964600080467d3
😎 Deploy Preview https://deploy-preview-10942--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 11, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/backend/google-firebase.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Keshav! Thank you for finding this one... we've been trying to "catch them all" and replace them, but some keep slipping through. 😄

One issue with making this change, though, is that the rest of the page assumes output: 'server' and therefore this guide would not work as intended without it.

All the routes would be server-rendered by default in this guide, so you would never need to say export const prerender = false to make this guide work. If you remove the server requirement, then this whole page needs to be checked and the line of code to prevent prerendering needs to be added to all the example files that do need to be server rendered.

So, if you'd like to continue with this change (which I think is a good one!), then you'll need to check the entire guide carefully, because it was written specifically for output: 'server' and this entire guide assumes routes will NOT be prerendered by default. Are you still interested in continuing with this?

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants