Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AstroJSX syntax [WIP] #828

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

goulvenclech
Copy link
Contributor

@goulvenclech goulvenclech commented Mar 13, 2024

Changes

Astro expression syntax is similar to JSX, but it's not JSX. So, we need to create a new syntax for it, including the JSX syntax as a base, and adding some Astro-specific patterns over it.

This will allow us to fix some issues much more easily, such as #708 or #714 . Also, the syntax will match the actual behaviour of Astro expressions, like basic HTML comments - not supported by JSX in expressions, but Astro does.

Testing

Will be tested. I swear.

Docs

N/A, this PR will make the syntax match the actual behaviour of Astro expressions. But the code is commented.

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: 9ebaa55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant