Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Add .cjs extension to node file suggestions #2265

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

yaronuliel
Copy link
Contributor

Resolving #2262

(previously submitted as #2263 )

@withfig-bot
Copy link
Collaborator

withfig-bot commented Feb 7, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot
Copy link
Collaborator

Overview

src/node.ts:

Info:

@yaronuliel
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@withfig-bot
Copy link
Collaborator

Hello @yaronuliel,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@yaronuliel
Copy link
Contributor Author

recheck

@grant0417 grant0417 merged commit c47cfab into withfig:master Feb 7, 2024
5 checks passed
@withfig withfig locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants