-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third delivery #51
Open
TheMaster1802
wants to merge
15
commits into
wizelineacademy:main
Choose a base branch
from
TheMaster1802:third_delivery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Third delivery #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses permission enabled Gradle - Adding Dependencies MainActivity - Setting up content container
- Adding Screens and Navigation MainActivity - Setting up navHost
- Adding Data Transfer Object (DTO) Interface for Retrofit - Adding AppModule and its provider for RetrofitInstance - Adding Models for Available Book, Ticker and Order Book - Adding New Class which extends from Application for Hilt annotation HiltAndroidApp - Name registration in Manifest MainActivity - Adding entry point Hilt annotation
- Generic Card component - New SVG Image for app Icon and PlaceHolder - Building up the Principal screen
- Setting up the Navigation flow in order to pass the book name as argument to Description Screen
- Implementing string resources in Principal and Description screens - Implementing dimens resources in Splash, Principal and Description screens - Implementing navigation resources in Principal and Description screens - Creation of new composables: DropDownMenu and RadioButton
- Interfaces were added into the project: Remote, Local and Cache - OkHttpInterceptor added in App module and implemented in Retrofit provider - Room elements added into the project: Model, Dao, Database and its respective implementations for Hilt
- Cache Room - Resource generic class - NetworkBoundResource class
- Improvement in retrieving or fetching data from view model
- Fixing the behavior in Generic Card
- Placing each api call in an independent coroutine
- Repository test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit Testing