Skip to content

Commit

Permalink
Remove local-user validation.
Browse files Browse the repository at this point in the history
This flag isn't required, and we're not really using it today. It's
usually used to inform the signing tool what key to use, but for keyless
signing we don't need this.

Leaving the flag in because we need it defined for git not to error out.
We may start using it as a mechanism to support BYO keys in the future.

Signed-off-by: Billy Lynch <[email protected]>
  • Loading branch information
wlynch committed Apr 10, 2024
1 parent 337b099 commit 0292617
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions internal/commands/root/sign.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ func commandSign(o *options, s *gsio.Streams, args ...string) error {
if o.FlagVerify {
return errors.New("specify --help, --sign, or --verify")
}
if len(o.FlagLocalUser) == 0 {
return errors.New("specify a USER-ID to sign with")
}

userIdent, err := fulcio.NewIdentity(ctx, o.Config, s.TTYIn, s.TTYOut)
if err != nil {
Expand Down
3 changes: 0 additions & 3 deletions internal/commands/root/verify.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ func commandVerify(o *options, s *gsio.Streams, args ...string) error {
if o.FlagSign {
return errors.New("specify --help, --sign, or --verify")
}
if len(o.FlagLocalUser) > 0 {
return errors.New("local-user cannot be specified for verification")
}
if o.FlagDetachedSignature {
return errors.New("detach-sign cannot be specified for verification")
}
Expand Down

0 comments on commit 0292617

Please sign in to comment.