Skip to content

Commit

Permalink
Run e2e Go tests first.
Browse files Browse the repository at this point in the history
I suspect why the e2e tests are failing is because we're running this
after the staging tests when the sigstore root has been changed to
staging.

Current the tests hardcode prod sigstore, which is likely what is causing the issues
since we're trying to verify a prod signature with the staging root.
TBD if this is the right thing to do (or if we should use staging instead),
but this should hopefully fix us for the time being.
  • Loading branch information
wlynch committed Mar 4, 2024
1 parent 6f20ffd commit 9166fff
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ jobs:
go-version: "1.21"
check-latest: true

- name: e2e unit tests
run: |
set -e
make e2e-test
- name: Install Gitsign
run: |
set -e
Expand Down Expand Up @@ -148,8 +153,3 @@ jobs:
- name: Debug log
if: failure()
run: cat "${GITSIGN_LOG}"

- name: e2e unit tests
run: |
set -e
make e2e-test

0 comments on commit 9166fff

Please sign in to comment.