Skip to content

Commit

Permalink
Replace phantomjs with chrome headless
Browse files Browse the repository at this point in the history
  • Loading branch information
MuhammadJaziraly committed Dec 26, 2024
1 parent 342ab23 commit 5005055
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,15 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Install Chrome
run: |
sudo apt-get update
sudo apt-get install -y chromium-browser
- name: Install dependencies
run: npm install

- name: Run ESLint and tests
run: npm test
run: npm test
env:
CHROME_BIN: /usr/bin/chromium-browser
2 changes: 1 addition & 1 deletion karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ module.exports = function ( config ) {
port: 9876,

logLevel: config.LOG_INFO,
browsers: [ 'PhantomJS' ]
browsers: [ 'ChromeHeadless' ]
} );
};
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
"eslint-config-wikimedia": "0.4.0",
"karma": "^6.1.0",
"karma-cli": "^1.0.1",
"karma-phantomjs-launcher": "^1.0.4",
"karma-chrome-launcher": "^3.1.0",
"puppeteer": "^21.0.0",
"karma-qunit": "^4.1.2",
"qunit": "^2.14.0"
},
Expand Down

0 comments on commit 5005055

Please sign in to comment.