Skip to content

Commit

Permalink
Merge pull request #125 from wmde/release090maybe
Browse files Browse the repository at this point in the history
Release 0.9.0
  • Loading branch information
thiemowmde authored Sep 6, 2017
2 parents 483edc4 + 8de1b4f commit 5744ba1
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 11 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@ On [Packagist](https://packagist.org/packages/data-values/javascript):

## Release notes

### 0.9.0 (dev)
### 0.9.0 (2017-09-06)
* Removed `valueFormatters.ValueFormatterStore`.
* Removed the `options` constructor parameter as well as the `getOptions` method from
`valueFormatters.ValueFormatter`.
* Removed `dataValues.DataValue.getSortKey` from the interface and all implementations.
* Removed `dataValues.TimeValue.getYear`, `getMonth`, `getDay`, `getHour`, `getMinute`, and
`getSecond`.
* Removed `dataValues.DataValue.getSortKey` from the interface and all implementations.
* Removed `globeCoordinate.GlobeCoordinate.iso6709`.
* Declared `globeCoordinate.GlobeCoordinate.getDecimal` private.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,22 @@ define( [
assert.expect( 9 );
var c;

assert['throws'](
assert.throws(
function() { c = new globeCoordinate.GlobeCoordinate( '' ); },
'Trying to instantiate with an empty value throws an error.'
);

assert['throws'](
assert.throws(
function() { c = new globeCoordinate.GlobeCoordinate( 'some string' ); },
'Trying to instantiate with an invalid value (some string) throws an error.'
);

assert['throws'](
assert.throws(
function() { c = new globeCoordinate.GlobeCoordinate( '190° 30" 1.123\'' ); },
'Trying to instantiate with an invalid value (190° 30" 1.123\') throws an error.'
);

assert['throws'](
assert.throws(
function() { c = new globeCoordinate.GlobeCoordinate( { latitude: 20 } ); },
'Trying to instantiate with an invalid value ({ latitude: 20 }) throws an error.'
);
Expand Down
8 changes: 4 additions & 4 deletions tests/src/valueParsers/ValueParserStore.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ define( [
QUnit.test( 'registerDataTypeParser(): Error handling', function( assert ) {
var parserStore = new vp.ValueParserStore();

assert['throws'](
assert.throws(
function() {
parserStore.registerDataTypeParser( 'invalid', stringType.getId() );
},
Expand All @@ -74,7 +74,7 @@ define( [

parserStore.registerDataTypeParser( StringParser, stringType.getId() );

assert['throws'](
assert.throws(
function() {
parserStore.getParser( stringType );
},
Expand All @@ -85,7 +85,7 @@ define( [
QUnit.test( 'registerDataValueParser(): Error handling', function( assert ) {
var parserStore = new vp.ValueParserStore();

assert['throws'](
assert.throws(
function() {
parserStore.registerDataValueParser( 'invalid', StringValue.TYPE );
},
Expand All @@ -94,7 +94,7 @@ define( [

parserStore.registerDataValueParser( StringParser, StringValue.TYPE );

assert['throws'](
assert.throws(
function() {
parserStore.getParser( StringValue );
},
Expand Down
2 changes: 1 addition & 1 deletion tests/src/values/TimeValue.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ define( [
for ( i = 0; i < invalidTimestamps.length; i++ ) {
invalidTimestamp = invalidTimestamps[i];

assert['throws'](
assert.throws(
function() {
dv.TimeValue( invalidTimestamp );
},
Expand Down

0 comments on commit 5744ba1

Please sign in to comment.