Merge pull request #135 from wmde/versionfix

Add missing release notes and @SInCE tags
wmde · Jun 8, 2015 · 84b2eac · 84b2eac
2 parents 543f414 + 6e58609
commit 84b2eac
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 18 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -9,6 +9,8 @@
 * Renamed `SerializerFactory::newSnaksSerializer` to `SerializerFactory::newSnakListSerializer`, leaving a b/c alias
 * Renamed `DeserializerFactory::newClaimDeserializer` to `DeserializerFactory::newStatementDeserializer`, leaving a b/c alias
 * Renamed `DeserializerFactory::newSnaksDeserializer` to `DeserializerFactory::newSnakListDeserializer`, leaving a b/c alias
+* Added `SerializerFactory::newStatementListSerializer`
+* Added `DeserializerFactory::newStatementListDeserializer`
 
 ## 1.3.0 (2015-01-28)
 

diff --git a/src/DeserializerFactory.php b/src/DeserializerFactory.php
@@ -54,9 +54,10 @@ public function __construct( Deserializer $dataValueDeserializer, EntityIdParser
 	 * @return DispatchableDeserializer
 	 */
 	public function newEntityDeserializer() {
+		$fingerprintDeserializer = new FingerprintDeserializer();
 		return new DispatchingDeserializer( array(
-			new ItemDeserializer( $this->newEntityIdDeserializer(), $this->newFingerprintDeserializer(), $this->newStatementListDeserializer(), $this->newSiteLinkDeserializer() ),
-			new PropertyDeserializer( $this->newEntityIdDeserializer(), $this->newFingerprintDeserializer(), $this->newStatementListDeserializer() )
+			new ItemDeserializer( $this->newEntityIdDeserializer(), $fingerprintDeserializer, $this->newStatementListDeserializer(), $this->newSiteLinkDeserializer() ),
+			new PropertyDeserializer( $this->newEntityIdDeserializer(), $fingerprintDeserializer, $this->newStatementListDeserializer() )
 		) );
 	}
 
@@ -81,6 +82,8 @@ public function newClaimsDeserializer() {
 	/**
 	 * Returns a Deserializer that can deserialize StatementList objects.
 	 *
+	 * @since 1.4
+	 *
 	 * @return Deserializer
 	 */
 	public function newStatementListDeserializer() {
@@ -134,6 +137,8 @@ public function newReferenceDeserializer() {
 	/**
 	 * Returns a Deserializer that can deserialize SnakList objects.
 	 *
+	 * @since 1.4
+	 *
 	 * @return Deserializer
 	 */
 	public function newSnakListDeserializer() {
@@ -144,6 +149,7 @@ public function newSnakListDeserializer() {
 	 * b/c alias for newSnakListDeserializer
 	 *
 	 * @deprecated since 1.4 - use newSnakListDeserializer instead
+	 *
 	 * @return Deserializer
 	 */
 	public function newSnaksDeserializer() {
@@ -168,13 +174,4 @@ public function newEntityIdDeserializer() {
 		return new EntityIdDeserializer( $this->entityIdParser );
 	}
 
-	/**
-	 * Returns a Deserializer that can deserialize Fingerprint objects.
-	 *
-	 * @return Deserializer
-	 */
-	public function newFingerprintDeserializer() {
-		return new FingerprintDeserializer();
-	}
-
 }
diff --git a/src/SerializerFactory.php b/src/SerializerFactory.php
@@ -97,6 +97,8 @@ public function newClaimsSerializer() {
 	/**
 	 * Returns a Serializer that can serialize StatementList objects.
 	 *
+	 * @since 1.4
+	 *
 	 * @return Serializer
 	 */
 	public function newStatementListSerializer() {
@@ -146,6 +148,8 @@ public function newReferenceSerializer() {
 	/**
 	 * Returns a Serializer that can serialize SnakList objects.
 	 *
+	 * @since 1.4
+	 *
 	 * @return Serializer
 	 */
 	public function newSnakListSerializer() {
@@ -156,6 +160,7 @@ public function newSnakListSerializer() {
 	 * b/c alias for newSnakListSerializer
 	 *
 	 * @deprecated since 1.4 - use newSnakListSerializer instead
+	 *
 	 * @return Serializer
 	 */
 	public function newSnaksSerializer() {

diff --git a/tests/unit/DeserializerFactoryTest.php b/tests/unit/DeserializerFactoryTest.php
@@ -130,11 +130,4 @@ public function testNewEntityIdDeserializer() {
 		);
 	}
 
-	public function testNewFingerprintDeserializer() {
-		$this->assertDeserializesWithoutException(
-			$this->buildDeserializerFactory()->newFingerprintDeserializer(),
-			array()
-		);
-	}
-
 }