Never ignore URL dependencies in PEP 723 noxfiles #935
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschaffner
force-pushed
the
fix-url-dep-pep-723-noxfile
branch
from
c552774 to
4a3878f
Compare
|
Actually, perhaps we should be parsing PEP 610 metadata here? |
|
I checked to see if we could just use |
henryiii
reviewed
Feb 20, 2025
| @@ -106,6 +106,8 @@ def check_dependencies(dependencies: list[str]) -> bool: | |||
| version = importlib.metadata.version(dep.name) | |||
| if not dep.specifier.contains(version): | |||
| return False | |||
| if dep.url: | |||
| return False | |||
There was a problem hiding this comment.
I think we could make this smarter, given the suggestion in build and importlib.metadata's .origin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934.
W.r.t. performance: On uv (the default, if available), uv caches based on the URL. On virtualenv however, the URL will get pulled and built/installed every time.
Ideally, for the virtualenv case, nox would do its own caching on the URL, similar to what the uv backend,
uv run -s noxfile.pyandpipx run noxfile.pyall do. I have not included that here since I wanted to keep the scope of this PR to the correctness issue. Caching can be added later if needed. URL dependencies in PEP 723 noxfiles are perhaps not a very common case anyway, so perhaps it is TBD whether it's worth it for Nox to build a serialization format for doing said caching?