Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at crypto callback docs #121

Merged
merged 2 commits into from
Mar 18, 2024
Merged

First pass at crypto callback docs #121

merged 2 commits into from
Mar 18, 2024

Conversation

bigbrett
Copy link
Contributor

No description provided.

@bigbrett bigbrett force-pushed the ccb-docs branch 3 times, most recently from c105613 to 8045aa9 Compare March 18, 2024 14:34
@bigbrett bigbrett self-assigned this Mar 18, 2024
@bigbrett bigbrett requested a review from dgarske March 18, 2024 14:34
@dgarske dgarske self-assigned this Mar 18, 2024
@dgarske
Copy link
Contributor

dgarske commented Mar 18, 2024

GitHub CI seems to be failing with 1.952 cat: api/md/tpm2_8h.md: No such file or directory?

dgarske
dgarske requested changes Mar 18, 2024
View reviewed changes
wolfSSL/src/chapter06.md Outdated

Full examples of crypto callbacks can be found in the following locations

VaultIC Crypto Callbacks: https://github.com/wolfSSL/wolfssl-examples/blob/master/ccb_vaultic/ccb_vaultic.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use hyperlink markdown formatting. I also fixed the wolfTPM link

Full examples of crypto callbacks can be found in the following locations:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dgarske dgarske removed their assignment Mar 18, 2024
@dgarske
Copy link
Contributor

dgarske commented Mar 18, 2024

@bigbrett : By the way... Thank you so much for documenting this! Excellent work

@bigbrett
review comments
9d306f9 
c syntax highlighting
@bigbrett bigbrett requested a review from dgarske March 18, 2024 21:46
@dgarske dgarske merged commit 52ad103 into wolfSSL:master Mar 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarske dgarske dgarske approved these changes

Assignees

@bigbrett bigbrett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigbrett @dgarske