Add wolfSSL support for realm-core #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbrett
requested changes
Oct 9, 2024
There was a problem hiding this comment.
@tmael nice work! Could you please add a README detailing instructions to get this working, as well as some brief details on how it works? I know you have the build script, but I imagine users may want a quick orientation/overview.
bigbrett
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Getting build errors when building with the script or when following the steps manually:
CMake Error at external/CMakeLists.txt:4 (add_subdirectory):
The source directory
/home/brett/workspace/wolfssl/osp/realm/realm-core/external/catch
does not contain a CMakeLists.txt file.
CMake Error at CMakeLists.txt:389 (target_compile_definitions):
Cannot specify compile definitions for target "Catch2" which is not built
by this project.
|
@tmael also pls add realm to the list of supported projects in the top-level OSP README.md |
bigbrett
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the @bigbrett initial work at realm/realm-core#6535. The realm-core project cannot accept the contribution due to licensing issues.
The changes have been rebased to recent releases, along with fixes and cleanup, and I created a script to test against a specific Git commit or release. Two patch files have been created for use:
realm-commit-a5e87a39.patch can be applied to version 13.26.0 (commit a5e87a39).
realm-commit-c729fc80.patch can be applied to the master development branch (commit c729fc80).