-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wolfSSL support for realm-core #204
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmael nice work! Could you please add a README detailing instructions to get this working, as well as some brief details on how it works? I know you have the build script, but I imagine users may want a quick orientation/overview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting build errors when building with the script or when following the steps manually:
CMake Error at external/CMakeLists.txt:4 (add_subdirectory):
The source directory
/home/brett/workspace/wolfssl/osp/realm/realm-core/external/catch
does not contain a CMakeLists.txt file.
CMake Error at CMakeLists.txt:389 (target_compile_definitions):
Cannot specify compile definitions for target "Catch2" which is not built
by this project.
@tmael also pls add realm to the list of supported projects in the top-level OSP README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified I can build and run test on linux after the latest changes
This PR is based on the @bigbrett initial work at realm/realm-core#6535. The realm-core project cannot accept the contribution due to licensing issues.
The changes have been rebased to recent releases, along with fixes and cleanup, and I created a script to test against a specific Git commit or release. Two patch files have been created for use:
realm-commit-a5e87a39.patch can be applied to version 13.26.0 (commit a5e87a39).
realm-commit-c729fc80.patch can be applied to the master development branch (commit c729fc80).