Add Espressif SPI support #368
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Aug 12, 2024
| static int _is_initialized_spi = FALSE; | ||
|
|
||
| int esp_spi_master_init() { | ||
| // SPI bus & device configuration |
There was a problem hiding this comment.
C style comments /* */. Please refactor all
|
|
||
| int esp_spi_master_init() { | ||
| // SPI bus & device configuration | ||
| spi_bus_config_t bus_cfg = { |
There was a problem hiding this comment.
Please add const if possible
|
|
||
| // FSPI (HOST_SPI2) on esp32-s3-wroom | ||
| #define PIN_NUM_MISO 13 |
There was a problem hiding this comment.
Consider #ifndef PIN_NUM_MISO to allow build-time override. Same for below.
| } | ||
|
|
||
| /* Aquire SPI bus and keep pulling CS */ | ||
| int tpm_spi_acquire() |
There was a problem hiding this comment.
static int tpm_spi_acquire(void)
|
|
||
| static int _is_initialized_spi = FALSE; | ||
|
|
||
| int esp_spi_master_init() { |
There was a problem hiding this comment.
static int esp_spi_master_init()
{
| int64_t timeout_expiry; | ||
| } *tpm_data; | ||
|
|
||
| static int _is_initialized_spi = FALSE; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is credit [David Safford] that kindly sent me a patch along with a brief description:
I've not had time to test this. I wanted to at least express my thanks to David and open this draft PR to let people know that it is in the works.